react-native-eva-icons icon indicating copy to clipboard operation
react-native-eva-icons copied to clipboard

App Crash on wrong name strings

Open borstessi opened this issue 4 years ago • 3 comments

🐛 Bug Report

App crash if the name string isnt found in the eva icon library.

To Reproduce

Steps to reproduce the behavior: Adding a wrong string for the icon name.

Expected behavior

Instead of throwing a violation there should be a testing mechanism which prevents of throwing a violation and return null instead of the icon with a wrong name string to prevent app crashes.

Link to runnable example or repository (highly encouraged)

React Native Eva Icons Version

newest

Environment information

IOS 13.3 / 13.4 Android 8/9


borstessi avatar Feb 27 '20 18:02 borstessi

i have same problem. how can we check if this icon exist?

mtalhagaoglu avatar Mar 20 '20 21:03 mtalhagaoglu

Hey @mtalhagaoglu you can check here

kushagraagent47 avatar Jan 31 '21 15:01 kushagraagent47

@kushagraagent47 I think what OP means is that the component should handle being passed values for the name prop that don't exist. Right now it throws an exception.

joeyfigaro avatar May 31 '21 16:05 joeyfigaro