nebular icon indicating copy to clipboard operation
nebular copied to clipboard

Angular v19

Open chankim206 opened this issue 1 year ago • 13 comments

Issue type

  • [ ] bug report
  • [x] feature request

Issue description

Since Angular v19 got released November 19, 2024. Thought I'd just submit the feature request in regards to that.

Current behavior: Nebular 14 does not support Angular 19, it expects Angular 18 as a dependency. When used with Angular 19, npm throws errors in regards to type definitions since dependcies and etc.

Expected behavior: Nebular should work out of the box with Angular 19

chankim206 avatar Nov 27 '24 17:11 chankim206

Reading through some other issues just ran into this. In case anyone finds this helpful https://github.com/akveo/nebular/issues/3213

chankim206 avatar Nov 27 '24 17:11 chankim206

Bump.

umagon avatar Dec 12 '24 19:12 umagon

for urgent case, use this command:

npm i --force

htaebi avatar Dec 17 '24 07:12 htaebi

Instead of npm i --force it's much better to override the specific dependencies required by the @nebular/* package being used. For example, for @nebular/security: https://github.com/akveo/nebular/issues/3192#issuecomment-1736534089

davidyee avatar Dec 17 '24 20:12 davidyee

Instead of npm i --force it's much better to override the specific dependencies required by the @nebular/* package being used. For example, for @nebular/security: #3192 (comment)

Yes, but I can't get themes to work in angular 19.

umagon avatar Dec 18 '24 17:12 umagon

Instead of npm i --force it's much better to override the specific dependencies required by the @nebular/* package being used. For example, for @nebular/security: #3192 (comment)

This worked for the Angular CLI ng update, but npm install still not working as @umagon said

I manage to skip also adding overwrite to @nebular/theme

"@nebular/theme": {
    "@angular/animations": "$@angular/animations",
    "@angular/common": "$@angular/common",
    "@angular/core": "$@angular/core",
    "@angular/router": "$@angular/router"
}

Note: I needed to clear the npm cache with npm cache clean --force


Edit: Found a problem, this don't work with @angular/cdk

rui-ad-monte avatar Dec 19 '24 11:12 rui-ad-monte

Do anyone know how to make themes work in Angular 19? I mean this stuff:

@forward "@nebular/theme/styles/theming";
@use "@nebular/theme/styles/theming" as *;
@use "@nebular/theme/styles/themes/default";

$nb-themes: nb-register-theme(
  (
    text-basic-color: #000,
    text-info-color: #0A8,
    text-primary-color: #80A,
    text-hint-color: #A08,
    text-warning-color: #5e6,
    card-border-radius: 0px,
  )
)

It was working before I updated. It no longer works.

umagon avatar Jan 02 '25 18:01 umagon

bump!

jkneepkens avatar Jan 06 '25 09:01 jkneepkens

Looking forward 👍

kisimediaDE avatar Jan 25 '25 19:01 kisimediaDE

I've created a PR for it: https://github.com/akveo/nebular/pull/3277 Let's see if it can be picked up and reviewed by the maintainers of this repo!

jkneepkens avatar Jan 28 '25 08:01 jkneepkens

@denStrigo any plans on merging the Angular 19 PR or can I help with getting support for Angular 19 to work?

jkneepkens avatar Mar 03 '25 09:03 jkneepkens

@jkneepkens: Nebular 15.0.0 was released 2 weeks ago with support for Angular 19 https://github.com/akveo/nebular/releases/tag/v15.0.0

kisimediaDE avatar Mar 03 '25 09:03 kisimediaDE

Do anyone know how to make themes work in Angular 19? I mean this stuff:

@forward "@nebular/theme/styles/theming";
@use "@nebular/theme/styles/theming" as *;
@use "@nebular/theme/styles/themes/default";

$nb-themes: nb-register-theme(
  (
    text-basic-color: #000,
    text-info-color: #0A8,
    text-primary-color: #80A,
    text-hint-color: #A08,
    text-warning-color: #5e6,
    card-border-radius: 0px,
  )
)

It was working before I updated. It no longer works.

I am facing the similar issue, have you got any fix for it?

aliveoceans avatar Mar 31 '25 20:03 aliveoceans