nebular icon indicating copy to clipboard operation
nebular copied to clipboard

fix(themes): fix typo

Open JGreenlee opened this issue 2 years ago • 2 comments

add space on line 99

previously missing space caused themes to malfunction, if whitespace sensitive during packing

JGreenlee avatar Aug 26 '22 04:08 JGreenlee

When will this be merged? Looks like a no brainer.

ewalddieser avatar Sep 10 '22 09:09 ewalddieser

Related with #3078

jgomesmv avatar Sep 15 '22 10:09 jgomesmv

My advice is modify the file directly while the PR is accepted to update the library version. image Thank you for your support guys

Lobaton2020 avatar Sep 23 '22 02:09 Lobaton2020

My advice is modify the file directly while the PR is accepted to update the library version. image Thank you for your support guys

Can confirm this will work :), well, locally.. I would like deploy too ^^ this is blocking.

sengirab avatar Sep 26 '22 08:09 sengirab

@Tibing :)

sengirab avatar Sep 26 '22 11:09 sengirab

Since i don't know when this will be merged, and i need it now for a deploy, i figured out a way to get this fixed properly until this has been merged:

npm i patch-package

"scripts": {
    "postinstall": "patch-package"
}

Open up node_modules/@nebular/theme/components/layout/_layout.component.theme.scss and add a space to line :99 like this: @media screen and (min-width: $layout-window-mode-max-width + 150px) {

Now generate a patch file for "patch-package": npx patch-package @nebular/theme.

Every npm install the fix will be patched :)

Cheers!

sengirab avatar Sep 26 '22 12:09 sengirab

When will the new version including this one be available?

flixd00 avatar Oct 13 '22 09:10 flixd00