nebular
nebular copied to clipboard
fix(themes): fix typo
add space on line 99
previously missing space caused themes to malfunction, if whitespace sensitive during packing
When will this be merged? Looks like a no brainer.
Related with #3078
My advice is modify the file directly while the PR is accepted to update the library version.
Thank you for your support guys
My advice is modify the file directly while the PR is accepted to update the library version.
Thank you for your support guys
Can confirm this will work :), well, locally.. I would like deploy too ^^ this is blocking.
@Tibing :)
Since i don't know when this will be merged, and i need it now for a deploy, i figured out a way to get this fixed properly until this has been merged:
npm i patch-package
"scripts": {
"postinstall": "patch-package"
}
Open up node_modules/@nebular/theme/components/layout/_layout.component.theme.scss
and add a space to line :99
like this: @media screen and (min-width: $layout-window-mode-max-width + 150px) {
Now generate a patch file for "patch-package": npx patch-package @nebular/theme
.
Every npm install the fix will be patched :)
Cheers!
When will the new version including this one be available?