nebular icon indicating copy to clipboard operation
nebular copied to clipboard

Add support of Angular 14

Open Jafried15 opened this issue 3 years ago • 12 comments

Jafried15 avatar Jun 30 '22 11:06 Jafried15

@Jafried15 Having same concern, i recently updated my project to angular 14, but nebular theme seems to broken. add support for angular 14

chiragbytes avatar Jul 14 '22 10:07 chiragbytes

For instance I didn't had any issue with npm i --force

HS-Joe avatar Jul 20 '22 18:07 HS-Joe

The right thing is not to use the install command with --force option.

RicardoArndt avatar Jul 21 '22 23:07 RicardoArndt

I am also running into this issue using "@nebular/security": "9.0.3" and "@angular/common": "14.0.6"

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: @ingenius-software/[email protected] npm ERR! Found: @angular/[email protected] npm ERR! node_modules/@angular/common npm ERR! @angular/common@"14.0.6" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @angular/common@"^13.0.0" from @nebular/[email protected] npm ERR! node_modules/@nebular/security npm ERR! @nebular/security@"9.0.3" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR!

estrudels avatar Aug 03 '22 14:08 estrudels

I too am having problems with it installing in a clean angular14 project.

lasertiger avatar Aug 20 '22 00:08 lasertiger

I too am having problems with it installing in a clean angular14 project.

I'll try to work on it and make a PR soon 🤞

TBG-FR avatar Aug 20 '22 15:08 TBG-FR

Loosing theme grid design system after upgrade to angular 14 and theme 9.0

ramprudvi avatar Aug 28 '22 16:08 ramprudvi

I'm facing the same issue. Are there any plans to support angular v14 soon? Cheers!

jgomesmv avatar Sep 13 '22 15:09 jgomesmv

Many dependency issues while installing

rashid-naico avatar Sep 14 '22 04:09 rashid-naico

any news on that?

giacomo avatar Sep 20 '22 09:09 giacomo

I'd like to ask how simple it is for nebular to either ignore already installed packages in the users package.json or to change the packages in its own file to be all angular 14 compatible. The latest release is 9.1.0-rc.4 about 6 days ago and it is using old versions of packages namely one is @angular/animations version 13 as stated here: @angular/animations@"^13.0.0" from @nebular/[email protected]

codered13 avatar Sep 21 '22 12:09 codered13

please update to angular 14

MammadK avatar Sep 21 '22 20:09 MammadK

I don't understand why no one realises the problem is nebular package needs other packages as part oof its install and they clash with the packages the user has already installed and that nebular uses older versions of them. It's not a simple angular 14 update. Nebular the package uses older other packages and the nebular package itself has to be updated to use the latest of all the packages it needs. I gave a example before of this but no one obviously reads the comments. Look at my previous comment. Once again an example of this is:

@angular/animations version 13 as stated here: @angular/animations@"^13.0.0" from @nebular/[email protected]

BTW this issue is the same problem as this one: but once again no one reads: https://github.com/akveo/nebular/issues/3073

codered13 avatar Sep 29 '22 00:09 codered13

@nnixaa do you have some news about this topic?

giacomo avatar Oct 06 '22 07:10 giacomo

Temporary solution is to add the 14.x versions to the overrides section in the package.json

"overrides": {
    "@angular/animations": "14.2.4",
    "@angular/cdk": "14.2.3",
    ....
}

Example:

"dependencies": {
    "@angular/animations": "14.2.4",
    "@angular/cdk": "14.2.3",
    "@angular/common": "14.2.4",
    "@angular/compiler": "14.2.4",
    "@angular/core": "14.2.4",
    "@nebular/theme": "^8.0.0",
    ...
},
"overrides": {
    "@angular/animations": "14.2.4",
    "@angular/cdk": "14.2.3",
    "@angular/common": "14.2.4",
    "@angular/compiler": "14.2.4",
    "@angular/core": "14.2.4"
}

Or install with peer-deps should also work: npm ci --legacy-peer-deps

basvandorst avatar Oct 06 '22 12:10 basvandorst

For me it's worked perfectly with "@angular/cli": "~14.1.3" but broken after I updated to "@angular/cdk": "^14.2.1".

yalesnikov avatar Oct 12 '22 03:10 yalesnikov

As I stated in my very first comment here. The issue is the package We are all trying to install while in adds angular 14 the other packages it tries to install are not compatible and are older than the ones the users already have as part of their solutions packages.json file in my case as I stated was animations. This package used a 13. Something version and mine was 14. Something. They would clash and the install would fail. This package here we are trying to install needs to check if the user has a more latest version if so then skip installing the version it needs. Simple. Also please note the duplicate ticket I stated above as it’s the same problem. People please read before providing incomplete answers. Done.

codered13 avatar Oct 12 '22 21:10 codered13

Just thought of an idea folks I guess you could backup your packages.json and then force install nebular but yes but after then if it installs older versions of packages it needs then to manually paste over them with what you had originally, I’m just thinking. I’ll give it a go later and comment back.

codered13 avatar Oct 14 '22 02:10 codered13

Temporary solution is to add the 14.x versions to the overrides section in the package.json

"overrides": {
    "@angular/animations": "14.2.4",
    "@angular/cdk": "14.2.3",
    ....
}

Example:

"dependencies": {
    "@angular/animations": "14.2.4",
    "@angular/cdk": "14.2.3",
    "@angular/common": "14.2.4",
    "@angular/compiler": "14.2.4",
    "@angular/core": "14.2.4",
    "@nebular/theme": "^8.0.0",
    ...
},
"overrides": {
    "@angular/animations": "14.2.4",
    "@angular/cdk": "14.2.3",
    "@angular/common": "14.2.4",
    "@angular/compiler": "14.2.4",
    "@angular/core": "14.2.4"
}

Or install with peer-deps should also work: npm ci --legacy-peer-deps

as promising as this workaround was, it's no use when updating with ng update., which is especially helpful migrating v13 -> v14 (Form... -> UntypedForm...) When using [email protected] it turns out overrides are respected only after removing package-lock.json and node_modules, then installing all dependencies once again. On the other hand bumping Angular version using ng update requires having these dependencies installed, so overrides are not detected then.

robgor3 avatar Oct 14 '22 06:10 robgor3

should be marked as closed since version 10 of nebular is out and angular 14.2.x is supported.

giacomo avatar Dec 20 '22 10:12 giacomo

good news, but already purchased a new theme

rashid-naico avatar Dec 20 '22 10:12 rashid-naico