nebular icon indicating copy to clipboard operation
nebular copied to clipboard

feat(auth): added firebase apple strategy

Open lukas-mertens opened this issue 3 years ago • 2 comments

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

I added a firebase apple strategy to allow authentication by apple id. This is crucial for platforms which feature an ios app, as apple requires app developers to allow people to use "sign in with apple" if other social logins are allowed as well. Therefore this is an important feature.

As it is not trivial to add the required firebase-settings to the current playground, this MR doesn't feature a playground/unit-tests yet. If you think I should work on that, please point me into the right direction, as the other strategies don't have unit-tests either, as far as I could see.

lukas-mertens avatar Feb 15 '22 11:02 lukas-mertens

Can you help me merging this PR please?

angelocorreia27 avatar May 15 '23 15:05 angelocorreia27

@yggg or some other maintainer would have to review and approve my change. Is an apple firebase auth strategy wished? If that is the case, I would rebase so that this can be merged

lukas-mertens avatar May 17 '23 09:05 lukas-mertens

As no reviewer seems to be available, I will close the PR

lukas-mertens avatar Mar 13 '24 11:03 lukas-mertens