nebular icon indicating copy to clipboard operation
nebular copied to clipboard

fix(layout): footer fixed position attribute

Open NicmeisteR opened this issue 4 years ago • 9 comments

The footer fixed attribute did not apply fixed positioning, although the docs in the API say it should.

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

This solves the fact that the "fixed" attribute on the Footer Layout did not apply fixed positioning. Linked issue: https://github.com/akveo/nebular/issues/237

NicmeisteR avatar Mar 11 '21 09:03 NicmeisteR

Good day @Tibing! Can you please take a look at the above, it refers to issue: https://github.com/akveo/nebular/issues/237

NicmeisteR avatar Mar 19 '21 06:03 NicmeisteR

Any feedback on this issue?

NicmeisteR avatar Jan 23 '23 13:01 NicmeisteR

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.78%. Comparing base (db9e556) to head (f8fdd48). Report is 158 commits behind head on master.

:exclamation: Current head f8fdd48 differs from pull request most recent head a9ad036

Please upload reports for the commit a9ad036 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
- Coverage   77.82%   77.78%   -0.05%     
==========================================
  Files         262      262              
  Lines        8229     8227       -2     
  Branches      896      896              
==========================================
- Hits         6404     6399       -5     
- Misses       1550     1553       +3     
  Partials      275      275              

see 1 file with indirect coverage changes

codecov[bot] avatar May 21 '24 11:05 codecov[bot]

Bumping, as it's been more than a year now.

NicmeisteR avatar May 21 '24 11:05 NicmeisteR

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 29 '24 11:05 sonarqubecloud[bot]

It's been 3 years 😢

image

NicmeisteR avatar Oct 31 '24 16:10 NicmeisteR

Hi @nnixaa , could you please have a look at this?

NicmeisteR avatar Oct 31 '24 16:10 NicmeisteR

Bump, hoping oneday this get's approved.

NicmeisteR avatar Nov 20 '24 20:11 NicmeisteR