nebular
nebular copied to clipboard
fix(layout): footer fixed position attribute
The footer fixed attribute did not apply fixed positioning, although the docs in the API say it should.
Please read and mark the following check list before creating a pull request:
- [X] I read and followed the CONTRIBUTING.md guide.
- [X] I read and followed the New Feature Checklist guide.
Short description of what this resolves:
This solves the fact that the "fixed" attribute on the Footer Layout did not apply fixed positioning. Linked issue: https://github.com/akveo/nebular/issues/237
Good day @Tibing! Can you please take a look at the above, it refers to issue: https://github.com/akveo/nebular/issues/237
Any feedback on this issue?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.78%. Comparing base (
db9e556) to head (f8fdd48). Report is 158 commits behind head on master.
:exclamation: Current head f8fdd48 differs from pull request most recent head a9ad036
Please upload reports for the commit a9ad036 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #2694 +/- ##
==========================================
- Coverage 77.82% 77.78% -0.05%
==========================================
Files 262 262
Lines 8229 8227 -2
Branches 896 896
==========================================
- Hits 6404 6399 -5
- Misses 1550 1553 +3
Partials 275 275
Bumping, as it's been more than a year now.
It's been 3 years 😢
Hi @nnixaa , could you please have a look at this?
Bump, hoping oneday this get's approved.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
