gournal

gournal copied to clipboard

Example 03 defines an incorrect FieldsKey func

13

I think that "main()" function in "examples/03" needs to be fixed. Check this line https://github.com/codedellemc/gournal/blob/master/examples/03/main.go#L48. Fourth param `args` in `func(ctx gournal.Context, lvl gournal.Level, fields map[string]interface{}, args ...interface{})` ... shall be...

germanvazquez-rfk

Should methods passing nil context like this `LOG.Info(nil, "nil context log")` use "gournal.DefaultContext" instead of "defaultCtx" In this line https://github.com/codedellemc/gournal/blob/master/gournal.go#L345 I would change the code to: ` ctx = Defaultcontext...

germanvazquez-rfk