awesome-java icon indicating copy to clipboard operation
awesome-java copied to clipboard

Add OkHttp

Open ManuInDenWolken opened this issue 1 year ago • 5 comments

OkHttp is a common-used HTTP client.

ManuInDenWolken avatar Jul 24 '22 15:07 ManuInDenWolken

OkHttp was removed in PR: https://github.com/akullpp/awesome-java/pull/858 as it is not written in Java (anymore)

shathor avatar Jul 25 '22 12:07 shathor

My bad. Nevertheless, it's still a commonly used library. Since it's used on the entire Java platform, it should be added in my opinion. This list represents a useful piece of resources for the Java programming language, thus also a candidate for this set.

ManuInDenWolken avatar Jul 26 '22 08:07 ManuInDenWolken

My bad. Nevertheless, it's still a commonly used library. Since it's used on the entire Java platform, it should be added in my opinion. This list represents a useful piece of resources for the Java programming language, thus also a candidate for this set.

As the description says, this repository is a "list of awesome frameworks, libraries and software for the Java programming language." Since "for" means exactly "for" and not "written in", that also includes dependencies commonly used in Java (too). OkHttp (and Javalin) are such dependencies. Your entire PR 858 got built upon this misunderstanding - also the fault of akullpp, I mean. For the cases, a base software is written in another language than Java while there's only a client for the Java platform, I chime in with your reason. But the libraries written in Kotlin, Groovy or Scala... if it's commonly used in Java, there should be a listing for it. Even if it's written in Kotlin. But once such items are removed from the list for the reasons stated, this list loses any practical use given to it by the philosophy it's built upon.

ManuInDenWolken avatar Jul 26 '22 09:07 ManuInDenWolken

I don't want to repeat the discussion from PR 858.

shathor avatar Jul 26 '22 21:07 shathor

And I won't. I understand your reasoning, but also see the practical aspects. I argue without consideration of other "awesome" libraries, and weigh what's the best practical option for people consulting this list. This PR remains open, and with a detailed reason it'll be merged.

ManuInDenWolken avatar Jul 28 '22 14:07 ManuInDenWolken