ktoml icon indicating copy to clipboard operation
ktoml copied to clipboard

Published 20 hours ago • verified publisher icon akuleshov7

Added support for Kotest tests

Open ILikeYourHat opened this issue 2 years ago • 5 comments

Addresses #123

  • Added Kotest framework to project
  • Rewritten all tests in ktoml-file and ktoml-source modules
  • Rewritten a few tests in ktoml-core module
  • Sometimes making minor improvements in tests, like migrating away from TomlTable.fullTableName method or removing unused classes

Hope that you would like the way tests look now, and accept my humble contribution :)

ILikeYourHat avatar Oct 18 '23 14:10 ILikeYourHat

Hey, thank you, you are awesome, we had big discussions about kotest https://github.com/akuleshov7/ktoml/issues/123 I will have a look and merge it

orchestr7 avatar Oct 18 '23 15:10 orchestr7

One more thing: I did this PR because I'm participating in the Hacktoberfest. I would be grateful if you add "hacktoberfest-accepted" label to this PR to make it count. But if for any reason you don't want to do it, I'm also ok with it 👍

ILikeYourHat avatar Oct 19 '23 07:10 ILikeYourHat

One more thing: I did this PR because I'm participating in the Hacktoberfest. I would be grateful if you add "hacktoberfest-accepted" label to this PR to make it count. But if for any reason you don't want to do it, I'm also ok with it 👍

Added, am I right?

orchestr7 avatar Oct 19 '23 08:10 orchestr7

Added, am I right?

Yes, thank you!

ILikeYourHat avatar Oct 19 '23 08:10 ILikeYourHat

Any update on this PR? Do you need anything more from me?

ILikeYourHat avatar Oct 31 '23 09:10 ILikeYourHat