kargo icon indicating copy to clipboard operation
kargo copied to clipboard

Rename `currentFreight` to `lastPromotedFreight`

Open alexmt opened this issue 2 years ago • 4 comments

"Current freight" is misleading since Kargo does not assess what stage is running. We should rename "Current freight" to "last promoted" to resolve the confusion.

alexmt avatar Sep 25 '23 15:09 alexmt

Hey @alexmt , I wanted to pick this issue

TheSwarnim avatar Oct 04 '23 19:10 TheSwarnim

@TheSwarnim I'd like us to hold off on this please...

#631 is underway and it's a pretty significant refactor of the back-end.

I want to wait and do this after that is taken care of in order to avoid some really heinous merge conflicts.

After #631 is all set, this is all yours.

krancour avatar Oct 04 '23 19:10 krancour

Thanks @krancour, I was going through the source code and set up the local project setup. Meanwhile I'll check if is their any good first issue I can start working on it!

TheSwarnim avatar Oct 04 '23 19:10 TheSwarnim

This issue would just be a rename of the existing field. But agree it should be held off until FreightCRD is implemented

Related to the issue is: https://github.com/akuity/kargo/issues/751

I will leave #751 open as whether or not we need observedFreight. IMO, it is not a priority to implement robust, out-of-band drift detection to power the observedFreight field. But at least with the rename of currentFreight to lastPromotedFreight, the implications of what the field means is clearer.

jessesuen avatar Oct 04 '23 19:10 jessesuen

@krancour Based on our discussion yesterday, it sounds like the currentFreight field is being deprecated and ultimately removed, as it's redundant.

Given that, going to close this issue... feel free to reopen if I misunderstood this

(see https://github.com/akuity/kargo/pull/2206)

rbreeze avatar Jun 27 '24 17:06 rbreeze

Good catch @rbreeze. This issue definitely is moot now.

krancour avatar Jun 27 '24 18:06 krancour