akuity
ui: stages have promotion options they should not (maybe)
Promotion to a control flow Stage has been, up to now, considered meaningless on account of having no steps to execute, and are therefore not allowed.
As long as that remains true, it appears there are a few invalid options currently available in the UI:
Removing the "promote from upstream" and "instant promote from upstream" options would be the quick and easy UI-only fix.
There is an alternative, which may be worth discussing:
Should promoting to a control flow Stage actually be allowed and have the same effect as using its "promote to downstream" option? i.e. Should promoting to a control flow Stage simply "spray" Promotions out to the right of the control flow Stage?
The possible benefit of that is just one more, possibly intuitive way, to approach promotions.
The possible downside is the effect of promoting to a control flow Stage might not be intuitively understood to be "spraying" Promotions out to the right of the control flow Stage. When someone selects "promote to downstream" on the control flow Stage, the "spray" effect is obvious. I think it's less so when promoting to a control flow Stage.
cc @jessesuen for guidance on whether to change the UI or change the rules.
@kunalsinghdadhwal I'm not sure if you read all the way to the end, but I don't want any movement on this issue until the maintainers have had the opportunity to discuss it.
@rpelczar and I discussed this this morning and decided on fixing this only in the UI and leaving the back end as it currently is -- i.e. considering promotion to a control flow Stage as an invalid action. We can revisit that in the future if there are other motivators for it.
All that said, I have also agreed to double-check that I can still reproduce this issue. I filed it two weeks ago, but @rpelczar couldn't reproduce it today using v1.8.0-rc.5.
Ball's in my court for now.