kargo icon indicating copy to clipboard operation
kargo copied to clipboard

chore: Adding init container support for the Controller in Helm

Open sbyrne13 opened this issue 9 months ago • 6 comments

There is currently no capability to add custom init container code into the controller. This is particularly useful for things like adding a binary or tool that is necessary for cloud compatibility.

Also adding volume and volume mount support too so that we can share installed binaries to the controller.

Some background here - https://github.com/akuity/kargo/issues/3750

sbyrne13 avatar Apr 16 '25 22:04 sbyrne13

Deploy Preview for docs-kargo-io ready!

Name Link
Latest commit d149c38afb4a2985dda23c8a5f56e355ebbabbe5
Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/680fdc17f371670008880dc7
Deploy Preview https://deploy-preview-3879.docs.kargo.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 16 '25 22:04 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.21%. Comparing base (1a504ad) to head (d149c38). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3879   +/-   ##
=======================================
  Coverage   53.21%   53.21%           
=======================================
  Files         312      312           
  Lines       28363    28363           
=======================================
  Hits        15094    15094           
  Misses      12478    12478           
  Partials      791      791           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 17 '25 09:04 codecov[bot]

@sbyrne13 codegen needs to be run after modifications to values.yaml. It's how the chart's readme gets updated based on metadata in that file.

krancour avatar Apr 17 '25 19:04 krancour

Ah okay - thanks @krancour - done!

sbyrne-teck avatar Apr 17 '25 19:04 sbyrne-teck

This LGTM, but requesting @hiddeco to voice any concerns if he has any.

fwiw, I momentarily contemplated whether this capability should be added to all the components, but I think the controller is the only one where it is likely needed, so I'm ok with doing just the one.

krancour avatar Apr 17 '25 20:04 krancour

@krancour - have updated this PR to also include volumes and volumeMounts after some more testing. Please re-review when you have some time. Thanks

sbyrne13 avatar Apr 17 '25 22:04 sbyrne13