kargo icon indicating copy to clipboard operation
kargo copied to clipboard

Close the PR when the Promotion is aborted

Open shabbir-saifee-cmm opened this issue 11 months ago • 5 comments

Checklist

  • [ X ] I've searched the issue queue to verify this is not a duplicate feature request.
  • [ X ] I've pasted the output of kargo version, if applicable.
  • [ X ] I've pasted logs, if applicable.

Proposed Feature

Close the PR when the Promotion is aborted

Image Image

Motivation

Suggested Implementation

shabbir-saifee-cmm avatar Feb 04 '25 15:02 shabbir-saifee-cmm

Noting here that this ought not be addressed in a vacuum.

#2972 aims to make behavior configurable when a Promotion fails (or is aborted, I suppose).

It would be best to solve that first.

fwiw, it may better to work in the other direction. Instead of aborting the Promo and counting on that to close the PR, you could close the PR and count on that to fail the Promo. That already works.

krancour avatar Feb 19 '25 15:02 krancour

Alternative proposal: https://github.com/akuity/kargo/issues/3639

jessesuen avatar Mar 11 '25 19:03 jessesuen

#3639 + a close-pr step would work nicely.

krancour avatar Mar 12 '25 04:03 krancour

This issue has been automatically marked as stale because it had no activity for 90 days. It will be closed if no activity occurs in the next 30 days but can be reopened if it becomes relevant again.

github-actions[bot] avatar Jun 10 '25 11:06 github-actions[bot]

This issue has been automatically marked as stale because it had no activity for 90 days. It will be closed if no activity occurs in the next 30 days but can be reopened if it becomes relevant again.

github-actions[bot] avatar Oct 24 '25 11:10 github-actions[bot]