Wrong tooltip while freight is being promoted

[alexmt]

Checklist

• [x] I've searched the issue queue to verify this is not a duplicate bug report.
• [x] I've included steps to reproduce the bug.
• [x] I've pasted the output of kargo version.
• [x] I've pasted logs, if applicable.

Description

Wrong tooltip while freight is being promoted. See attached screenshot.

Screenshots

Steps to Reproduce

Trying to promote frieght to any stage

Version

v1.1.1

[Marvin9]

@krancour / @hiddeco did we remove or move to somewhere else the freight details in stage's current promotion field?

[krancour]

If we did, it was a long time ago.

If you point me to where in the UI code I can find this tooltip, I can investigate.

[Marvin9]

Sure.. there you go @krancour

Promotion reference has that attribute so its not giving type error, I assume the use of it was discarded at some point

[krancour]

Thanks @Marvin9!

Hmmm. That field should be set.

This smells like a back end problem. 👀

[krancour]

I'll take this one over for now.

[nitishfy]

After discussing with @krancour , I'll be taking this one.

[nitishfy]

While looking into potential causes, I came across the following error in the reconciler setup:

Cannot use 'predicate.GenerationChangedPredicate{}' (type predicate.GenerationChangedPredicate) as the type TypedPredicate[object] 
Type does not implement 'TypedPredicate[object]' need the method: Update(event.TypedUpdateEvent[object]) bool 
have the method: Update(e event.TypedUpdateEvent[object]) bool

References:

• https://github.com/akuity/kargo/blob/main/internal/controller/stages/regular_stages.go#L171
• https://github.com/akuity/kargo/blob/main/internal/controller/warehouses/warehouses.go#L96

I'm not sure if this could be related to the tooltip issue, but I wanted to check if this might be affecting how Freight is being processed. Additionally, can anyone guide me on which part of the source code I should focus on to debug this further? Any pointers on where the tooltip gets its data from would be really helpful.

[krancour]

That error is unrelated, but worth looking into independently of this. Please open another issue.

Additionally, can anyone guide me on which part of the source code I should focus on to debug this further? Any pointers on where the tooltip gets its data from would be really helpful.

@Marvin9 linked to relevant UI code here, but the links weren't permalinks, and it seems the files in question have changed enough that the links are no longer pointing to the relevant lines.

🙏 @Marvin9 can you possibly provide some updated links to help @nitishfy can see more clearly where the UI gets the data from, so he can dig in deeper on the back end and see what's going on?

[Marvin9]

Sure. This is the source for UI. You can observe the stage's live manifest to debug the issue. Basically this field must have freight's name

[nitishfy]

That error is unrelated, but worth looking into independently of this. Please open another issue

Issue created

[krancour]

@nitishfy please lmk if you need someone from my team to take this over.

[nitishfy]

@krancour sorry for the delay. I've been caught up with some other work. Please assign this to someone from your team. Thank you!

[krancour]

@Marvin9 @rpelczar is this already fixed in #3941?

Or do we still think it's a back end issue?

[Marvin9]

I think its backend issue but new pipeline revamp just lead you to granular details of promotion

[krancour]

So potentially a non-issue now then?

[Marvin9]

I think so, feel free to reopen otherwise