kargo icon indicating copy to clipboard operation
kargo copied to clipboard

Invalid health status of a Argo CD backed stage

Open alexmt opened this issue 1 year ago • 7 comments

Description

Kargo UI shows that related Argo CD app health is Degraded although it is Healthy.

Screenshots

image
    - type: Healthy
      status: "False"
      observedGeneration: "9"
      lastTransitionTime: 2024-11-26T19:49:14Z
      reason: LastPromotionErrored
      message: Last Promotion did not succeed
    - type: Verified
      status: "True"
      observedGeneration: "9"
      lastTransitionTime: 2024-11-26T19:49:14Z
      reason: Verified
      message: Freight has been verified

Steps to Reproduce

I belive this is happening if most recent promotion failed.

Version

v1.1.1

alexmt avatar Dec 18 '24 19:12 alexmt

It was by design. Especially with promotion processes being user-defined and very open ended, it's become pretty much impossible after a failed promotion to assert whether the current state of the world is good or not. Underlying apps might be healthy, but that doesn't mean that, big picture, everything is actually ok. Suppose for instance that a Stage uses a promotion process that pushes different things to multiple branches, multiple repos, or even interacts with external systems through the http step. If some of those steps succeeded and some failed, it's possible -- even likely -- that the current state of the world is invalid even if any/all underlying apps say they're healthy.

krancour avatar Dec 19 '24 01:12 krancour

That is sad :( It makes UI confusing for whose who use Kargo with Argo CD

alexmt avatar Dec 19 '24 16:12 alexmt

This issue has been automatically marked as stale because it had no activity for 90 days. It will be closed if no activity occurs in the next 30 days but can be reopened if it becomes relevant again.

github-actions[bot] avatar Mar 20 '25 11:03 github-actions[bot]

Not stale.

#3558 made some progress on this we may be able to build a more comprehensive fix on top of #3603.

krancour avatar Mar 20 '25 13:03 krancour

This issue has been automatically marked as stale because it had no activity for 90 days. It will be closed if no activity occurs in the next 30 days but can be reopened if it becomes relevant again.

github-actions[bot] avatar Jun 19 '25 11:06 github-actions[bot]

Not stale

fykaa avatar Jun 24 '25 16:06 fykaa

This issue has been automatically marked as stale because it had no activity for 90 days. It will be closed if no activity occurs in the next 30 days but can be reopened if it becomes relevant again.

github-actions[bot] avatar Oct 30 '25 11:10 github-actions[bot]