kargo icon indicating copy to clipboard operation
kargo copied to clipboard

feat(ui): ability to collapse all unused freight

Open rbreeze opened this issue 1 year ago • 2 comments

Fixes #2386

CleanShot 2024-08-06 at 12 02 50@2x CleanShot 2024-08-06 at 12 02 42@2x CleanShot 2024-08-06 at 12 03 07@2x

rbreeze avatar Aug 06 '24 19:08 rbreeze

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
Latest commit 71ac2673deec01f14cfd8ef9e8790e77d213e8b8
Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66c693106fe104000881a47c
Deploy Preview https://deploy-preview-2393.kargo.akuity.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 06 '24 19:08 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.44%. Comparing base (bab3322) to head (71ac267). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2393   +/-   ##
=======================================
  Coverage   48.44%   48.44%           
=======================================
  Files         246      246           
  Lines       17726    17726           
=======================================
  Hits         8587     8587           
  Misses       8713     8713           
  Partials      426      426           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 06 '24 19:08 codecov[bot]

Seeing some issues with this:

  1. When I collapse unused, the box that represents the unused Freight says "Old Freight," which is somewhat misleading, since hiding old Freight is a separate feature.

  2. When I hide old Freight, it's not hiding all the old Freight, but just the one oldest. The count that it shows in the box that represents the old Freight is off -- reflecting the number that it should have hidden.

N.B.: Don't be fooled by version numbers in this video. I manually created Freight containing references to older images. The chronological order in the Freight timeline is correct.

https://github.com/user-attachments/assets/3663d104-894c-4c4a-a503-a42cd1d135c0

krancour avatar Aug 16 '24 20:08 krancour

@krancour Thanks for finding the bug with the old freight collapsing improperly. Just pushed a fix.

WRT the "old freight" label, I chose to label the oldest set of collapsed freight as "old" no matter which collapse mode is chosen. My thinking is that no matter whether all unused freight are hidden or not, that last set is always "old". I can certainly see how this could be confusing though, so I'm happy to change it. WDYT?

Here's an example of all freight collapsed with the old freight label for the last group: Screenshot 2024-08-21 at 18 22 33

rbreeze avatar Aug 22 '24 01:08 rbreeze

I chose to label the oldest set of collapsed freight as "old" no matter which collapse mode is chosen

That makes sense!

krancour avatar Aug 22 '24 22:08 krancour