feat(ui): ability to collapse all unused freight
Fixes #2386
Deploy Preview for docs-kargo-akuity-io ready!
| Name | Link |
|---|---|
| Latest commit | 71ac2673deec01f14cfd8ef9e8790e77d213e8b8 |
| Latest deploy log | https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66c693106fe104000881a47c |
| Deploy Preview | https://deploy-preview-2393.kargo.akuity.io |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 48.44%. Comparing base (
bab3322) to head (71ac267). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2393 +/- ##
=======================================
Coverage 48.44% 48.44%
=======================================
Files 246 246
Lines 17726 17726
=======================================
Hits 8587 8587
Misses 8713 8713
Partials 426 426
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seeing some issues with this:
-
When I collapse unused, the box that represents the unused Freight says "Old Freight," which is somewhat misleading, since hiding old Freight is a separate feature.
-
When I hide old Freight, it's not hiding all the old Freight, but just the one oldest. The count that it shows in the box that represents the old Freight is off -- reflecting the number that it should have hidden.
N.B.: Don't be fooled by version numbers in this video. I manually created Freight containing references to older images. The chronological order in the Freight timeline is correct.
https://github.com/user-attachments/assets/3663d104-894c-4c4a-a503-a42cd1d135c0
@krancour Thanks for finding the bug with the old freight collapsing improperly. Just pushed a fix.
WRT the "old freight" label, I chose to label the oldest set of collapsed freight as "old" no matter which collapse mode is chosen. My thinking is that no matter whether all unused freight are hidden or not, that last set is always "old". I can certainly see how this could be confusing though, so I'm happy to change it. WDYT?
Here's an example of all freight collapsed with the old freight label for the last group:
I chose to label the oldest set of collapsed freight as "old" no matter which collapse mode is chosen
That makes sense!