kargo icon indicating copy to clipboard operation
kargo copied to clipboard

feat(ui): move image processing to backend

Open rbreeze opened this issue 1 year ago • 2 comments

Additionally, when a user creates a project, the images table will now be hidden by default. Once they create a Warehouse and promote a Stage, it will be shown again by default, at which point they can show / hide and it the preference will be stored in LocalStorage as it is now.

rbreeze avatar Aug 05 '24 21:08 rbreeze

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
Latest commit 80e06c49f5b21b9c5dd3da903cd2be7181ec384d
Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66c7c56623947800082bc9ce
Deploy Preview https://deploy-preview-2389.kargo.akuity.io
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 05 '24 21:08 netlify[bot]

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 48.35%. Comparing base (bab3322) to head (80e06c4). Report is 2 commits behind head on main.

Files Patch % Lines
internal/api/list_images_v1alpha1.go 0.00% 33 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2389      +/-   ##
==========================================
- Coverage   48.44%   48.35%   -0.10%     
==========================================
  Files         246      247       +1     
  Lines       17726    17759      +33     
==========================================
  Hits         8587     8587              
- Misses       8713     8746      +33     
  Partials      426      426              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 05 '24 21:08 codecov[bot]

@rbreeze thinking about this more and I think this endpoint is a little odd in that it returns something another endpoint already returns (list of Stages) and supplementary information used by the UI only.

If you don't mind making two API calls from the UI instead of one, I think it would be tidier if the UI continued to call out to the original list Stages endpoint and then made a second call to a new endpoint that returns just the image info.

krancour avatar Aug 12 '24 14:08 krancour