kargo icon indicating copy to clipboard operation
kargo copied to clipboard

cli: add `kargo server` command

Open krancour opened this issue 10 months ago • 10 comments

Extracted from #1569:

Jesse:

  • Kargo API server is not exposed in a shared manner
  • End users are given access to a portion of the cluster via kubeconfig
  • Users could still have a UI to do their thing

This would be different from the bygone --local-server option because it only did this:

Kent: adding --local-server to a command launches an ephemeral server that lives for the life of the command it's carrying out.

krancour avatar Apr 02 '24 16:04 krancour

Is this already done? I seem to recall seeing this command when I was last playing around with The CLI

webstradev avatar Apr 12 '24 17:04 webstradev

This is still an open issue, and I kind-of documented a blueprint for what is required here in https://github.com/akuity/kargo/blob/620d541f7a2081773e0f6f664e2b86e75358bea4/internal/cli/cmd/server/server.go#L68-L78

hiddeco avatar Apr 12 '24 19:04 hiddeco

//The server should be started with a Kubernetes client which does NOT // make use of an authorization wrapper.

This seems as if it's already taken care of.

It should allow the user to visit the UI in their browser.

I actually solved part of this problem locally and hadn't PR'ed it yet. Will open.

The rest certainly does remain outstanding...

A big gotcha is the UI currently doesn't accommodate the possibility of no authn at all. I'm going to open that specific item as a separate issue.

krancour avatar Apr 12 '24 21:04 krancour

Opened #1834 for the UI to hopefully gain the possibility of skipping the login page.

#1833 embeds UI assets in both the CLI and control plane binaries.

krancour avatar Apr 12 '24 22:04 krancour

Is this still a valid issue?

hanshal101 avatar Jul 30 '24 16:07 hanshal101

@hanshal101 no one has really been pushing for it. I believe this is something we could still entertain if someone really wants it and wants to do the work. That said, #1833 is a pre-requisite for this and also isn't a priority, because the only real reason to tackle #1833 would be to clear the way for this. i.e. Someone would probably have to take ownership of both those issues in order for there to be some movement here.

krancour avatar Jul 30 '24 20:07 krancour

Hey @krancour I would like to work on this. Since I'm new to this community could you please guide me on further steps?

hanshal101 avatar Jul 31 '24 12:07 hanshal101

@hanshal101 do you personally have a use case for this or are you just looking to grab an issue to work on?

This issue was opened to replace similar functionality (--local-serve) that was removed, but as I said, I haven't heard of anyone really pushing to get this issue resolved.

The thing I want to avoid is implementing this "just because."

And as I mentioned, #1833 is a prereq for this and seems to me to be a much harder issue than this one.

krancour avatar Jul 31 '24 12:07 krancour

@hanshal101 do you personally have a use case for this or are you just looking to grab an issue to work on?

This issue was opened to replace similar functionality (--local-serve) that was removed, but as I said, I haven't heard of anyone really pushing to get this issue resolved.

The thing I want to avoid is implementing this "just because."

And as I mentioned, #1833 is a prereq for this and seems to me to be a much harder issue than this one.

To be honest I'm just grabbing an issue ro work on it

hanshal101 avatar Jul 31 '24 14:07 hanshal101

To be honest I'm just grabbing an issue ro work on it

Gotcha. I wouldn't suggest this one unless you personally needed it because it's not clear anymore that this feature is badly needed.

#2363 or #2271 might be better first issues.

krancour avatar Jul 31 '24 16:07 krancour