Amit Kumar

Results 188 comments of Amit Kumar

Hi all, I am the creator of Cirun.io, "GPU Testing" caught my eye. FWIW I'll share my two cents. I created a service for problems like these, which is basically...

It doesn't seems you are running flake8 in travis. https://travis-ci.org/pydsa/pydsa/jobs/123176385

> @im-batman This is a connection/python installation issue on your side. I agree with this.

@NitikaAgarwal You need to update the directory of sorting algorithms in tests also.

This document could be cleaned up and added. https://github.com/pydsa/pydsa/wiki/Contributing-to-PyDSA

Thanks for the PR. Please add tests.

Yes, you can run tests locally on your computer. See this: https://github.com/pydsa/pydsa/wiki/Writing-and-Running-Tests-in-PyDSA

It seems you are directly calling a module rather than calling the function inside the module. For e.g. `bfs.py` is a module and `def bfs(..` is a function inside the...

A general note: Since PyDSA would be used by beginners, Its very important to focus on the code readability, try to simplify the code as much as possible.

@DeepanshuKapoor Please fix failing tests: `ImportError: No module named 'sorting'`