sliding_up_panel icon indicating copy to clipboard operation
sliding_up_panel copied to clipboard

Fix issue #289 (unable to scroll to the bottom of the body's Widget when used with a Scaffold)

Open qixotic opened this issue 3 years ago • 3 comments

This should fix #289 by modifying the builder to respect the parent's width/height constraints.

Also tweaks a few files so that one can build the example on iOS.

Looks like this issue has affected many versions, with a few PRs attempting to fix it or otherwise related: #44 #64 #92 #129. 64&92 take the same core approach of passing in constraints via a LayoutBuilder.

qixotic avatar May 09 '22 17:05 qixotic

Great fix, cloud you pub your version directly, as it takes so long time from #44 (2019), this repo seems dead..

ayqy avatar Sep 26 '22 01:09 ayqy

Great fix, cloud you pub your version directly, as it takes so long time from #44 (2019), this repo seems dead..

Added a tag to my repo so you could also just reference this fix in your pubspec.yaml if you don't need any other proposed PRs by others:

  sliding_up_panel:
    git:
      url: https://github.com/qixotic/sliding_up_panel
      ref: v2.0.0+1-Pull303

qixotic avatar Oct 04 '22 16:10 qixotic

@qixotic Hey, I know it's been a long time since you've created this PR, but shouldn't it also take into account the minHeight? Otherwise, when collapsed, my body is still partially hidden.

What I did (in this part):

child: Container(
           height: constraints.maxHeight - widget.minHeight,
           width: constraints.maxWidth,
           child: widget.body,
),

Does this make sense?

Thanks

leonardo2204 avatar Mar 13 '23 03:03 leonardo2204