meditate-app icon indicating copy to clipboard operation
meditate-app copied to clipboard

[New feature] Quote fetcher

Open Glomels opened this issue 4 years ago • 4 comments

Display a quote at the top from a local array of quotes. Click on the quote div to trigger a quote change. Quote automatically changes every 15 seconds.

Limited to 150 character or less for responsive purposes.

Glomels avatar Oct 02 '19 01:10 Glomels

@Glomels This feature is good but on testing, it seems like the changeQuote function is going haywire after a few quote changes. It starts changing the quotes way too rapidly.

Also, the placement looks fine but fonts and alignment seems to be lacking a lot in the current state of the feature.

akshat157 avatar Oct 02 '19 13:10 akshat157

@Glomels This feature is good but on testing, it seems like the changeQuote function is going haywire after a few quote changes. It starts changing the quotes way too rapidly.

Also, the placement looks fine but fonts and alignment seems to be lacking a lot in the current state of the feature.

I'm using the same font as the buttons, seemed fine to me. Should it be something more cursive or artsy?

Glomels avatar Oct 02 '19 16:10 Glomels

I think it looks good this way. I decided to put a shorter character limit when on mobile view by getting the viewport width with javascript. Generally fonts are bigger and have other small changes, get smaller under 767px screen size.

Glomels avatar Oct 02 '19 17:10 Glomels

Aesthetics were secondary. The major problem was with the quotes rapidly and randomly changing after a while. I'm actually viewing it on desktop currently, since I didn't plan a mobile version yet but yes, its good to see you already took it into account. No worries, I'll review it and make the required changes in a while. Thanks for the contribution! :smile:

akshat157 avatar Oct 02 '19 18:10 akshat157