odoo-usability icon indicating copy to clipboard operation
odoo-usability copied to clipboard

[11.0][MIG] account_invoice_update_wizard

Open grindtildeath opened this issue 6 years ago • 3 comments

Supersedes: #75 (as author repository doesn't exist anymore)

grindtildeath avatar Oct 16 '19 13:10 grindtildeath

Hello @sebastienbeau do you have time to give us a feedback about this?

leemannd avatar Oct 16 '19 14:10 leemannd

I don't want to anticipate @sebastienbeau response, but sadly Akretion skipped Odoo 11.0 version entirely (it's quite counter productive to try to be expert in every version) so we easily review PRs against 10.0 and 12.0, but for 11.0 it's much less likely...

rvalyi avatar Oct 16 '19 18:10 rvalyi

@rvalyi @sebastienbeau If you're using this module in v12.0, you might want to refactor this part: https://github.com/akretion/odoo-usability/blob/12.0/account_invoice_update_wizard/models/account_invoice.py#L12-L21

This was probably done to avoid having the wizard overwrite the changes done manually when calling its action (as create is called from the UI, the values were overwritten by default_get), but IMO the solution here is cleaner.

grindtildeath avatar Oct 21 '19 12:10 grindtildeath