Rob Allen

Results 128 comments of Rob Allen

i.e. if I add an email element and specify an additional validator that the length must be greater than 5, does this PR mean that the EmailAddress validator is no...

Thanks for letting us know Sandro. The tests work locally for me and passed on CI in #1181 just now, so there's something different here. I'll look into it.

Hi, It would be helpful if you could provide the generated PDF and log file that is in `tests/output` for these failed tests.

Error handling feels like the hardest part of Slim and we've had a few runs at it with different approaches in versions 2, 3 and 4. I'm confident that we...

In this case, the test against `displayErrorDetails` being set to `false` is correct. The idea here is that we we add a tip to the log to remind the developer...

As per your original report, the code is not using the wrong flag as the `writeToErrorLog` function is _intended_ to add an additional string to the logged error if `displayErrorDetails`...

Having said that, you have now provided additional information about an actual problem you have that you did not provide in the original report which shows that there is an...

As I now understand it, the actual problem is that we are adding a plain text string to the output provided by an error renderer, where that renderer's output may...

> I'm still uncertain about your understanding regarding the intention of the code. > > You can check where the function is called. If you check, you'll get to line...

The important thing is that ``` if (!$this->displayErrorDetails) { $body .= "\nTips: To display error details in HTTP response "; $body .= 'set "displayErrorDetails" to true in the ErrorHandler constructor.';...