Alex Bakon

Results 39 comments of Alex Bakon

@rodaine @kothariaditya can you chime in?

Checking in is okay; see https://github.com/envoyproxy/protoc-gen-validate/blob/ff16dc3486cd0ba925e260809be3076dac60780f/Makefile#L143-L152 for how to use CI to make sure it stays in sync.

I don't see why it wouldn't be safe to read in parallel

I was looking at the analogous code in the other WASM SDK repos and realized that, unlike Rust, those languages don't have separate types for "valid UTF-8 strings" and byte...

@taiki-e pinging you since you approved PR 311, which was in a similar area. Can you TAL or help me find a reviewer?

Thank you very much for the review. This is my first serious foray into unsafe Rust, so I'm not at all surprised that what I wrote was unsound! The example...

I don't have time to work on this now, so if someone wants to take over and do the refactor, go for it!

How much do the labels actually matter? The digest generation currently just serializes the `BTreeMap` [here](https://github.com/bazelbuild/rules_rust/blob/aa6e74ec802ca07df601c33939ac6c37c002fdec/crate_universe/src/splicing.rs#L106) and uses that as an input to the digest generation. Could we just, during...