Alfred Klomp

Results 69 comments of Alfred Klomp

Thanks! Let's have a library that can at least strictly validate. If at any later moment we want to relax the validation, we could create a flag for it. (Personally,...

Maybe one comment: it's quite common for base64 input to contain whitespace (newlines and such), and it would be helpful to have a flag to tell the library to ignore...

Hm, I'd like to avoid changing the API if possible. Your suggested addition basically checks if there are no trailing characters in the decode buffer. I'm not sure I consider...

The viewpoint changes depending on how you conceptualize the buffer. If you define it as being strictly a Base64-encoded string and nothing more, you get a different viewpoint than when...

Thanks for the contribution. Not sure I'm entirely on board with it yet. So this would cause the library to automatically recompile when the compiler flags are changed in the...

I intend to close this PR without merging it. I'm still not really on board with the change, as my earlier comment clarifies, and there have also been a lot...

Hi, thanks for raising this issue. Always interesting to get some perspective from a library user. I'll address your points specifically below, but first I want to clarify the design...

Hi! Currently this library only supports the [standard](https://github.com/aklomp/base64/blob/master/lib/tables/tables.c#L5) Base64 alphabet. It would probably be feasible, but difficult, to add support for additional alphabets. It could be non-trivial to add that...

This relates to #67. In that issue, I remarked that I consider it a reasonable thing for a `base64` library to claim the `base64` namespace. I am still partial to...

I'm tending towards `akbase64` as a pretty short and reasonably memorable name.