Alexey Kulakov

Results 65 comments of Alexey Kulakov

this change only effected embroider-optimized scenario, main is failing on ember-beta, I will take a look in detail what might be happening

I have investigated more, it seems that tests are only failing for modal/flyout etc. anything that uses `DialogPrimitive`, also tests are extremely flaky locally if I run full test suite...

tested on: * `cloud-ui` - `embroider/webpack` + `ember-engines` * `terraform-enterprise` - `embroider/vite` no `ember-engines`

we have just ran into this issues while migrating to Vite, I just wanted to confirm that multi yaml translation setup would not work with current addon version even with...

I will put it on hold, SFC work might supersede this PR

I think it's ready now, I have updated description, but let me know if it;s even worth merging this since this issues will keep coming up till we switch over...

this potentially breaking, I think to be safe we should target v5 for this change, maybe.

> > this potentially breaking, I think to be safe we should target v5 for this change, maybe. > > What do you think is breaking? Since there are consumer...

Yeah I tand to agree that this is very edge case where we legitimately using `templates/components` as route templates. I guess we just going to keep local patch and wait...

that is a good question, I will give it try tho it might be ways out till we are able to move to SFC for this project. I report back...