akka.net icon indicating copy to clipboard operation
akka.net copied to clipboard

[TestKit] SupervisorStrategy for TestActor is unused

Open roee88 opened this issue 1 year ago • 1 comments

Version Information

v1.5

Describe the bug

https://github.com/akkadotnet/akka.net/pull/4148 added public IActorRef ChildActorOf(Props props, string name, SupervisorStrategy supervisorStrategy) and similar methods to TestKitBase. However, the supervisorStrategy does not take effect.

It looks like InternalTestActor doesn't override SupervisorStrategy() to actually use its private _supervisorStrategy. See https://github.com/akkadotnet/akka.net/blob/0782c7dc069618e20a3791aaab667076f487ad96/src/core/Akka.TestKit/Internal/InternalTestActor.cs#L24

roee88 avatar Jan 14 '24 20:01 roee88

Thanks, we'll look into this

Aaronontheweb avatar Jan 16 '24 20:01 Aaronontheweb