akka-persistence-jdbc icon indicating copy to clipboard operation
akka-persistence-jdbc copied to clipboard

poolName defined for different connection pools

Open Zuchos opened this issue 4 years ago • 4 comments

When DB configuration is reused it's wise to set up different connection pool name for monitoring/debugging purposes. I would said that having 3 connection pools with same name is bad practice, so it should not be in reference conf.

Zuchos avatar Oct 08 '20 07:10 Zuchos

Hi @Zuchos,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Oct 08 '20 07:10 lightbend-cla-validator

These files are not only for the tests, but we also link to this file in the documentation: https://doc.akka.io/docs/akka-persistence-jdbc/current/#sharing-the-database-connection-pool-between-the-journals

I guess it makes sense to configure these settings for all databases, so that our documentation includes the pool names in the examples

WellingR avatar Jan 14 '21 16:01 WellingR

In that case, we should have for all DBs and also for the shared db settings.

octonato avatar Jan 14 '21 20:01 octonato

@Zuchos Is this something you would like to complete or shall we close? Then it should include that setting for the other database configuration also.

patriknw avatar Aug 16 '22 11:08 patriknw

Closing for inactivity.

ennru avatar Mar 25 '24 18:03 ennru