akka-persistence-jdbc
akka-persistence-jdbc copied to clipboard
poolName defined for different connection pools
When DB configuration is reused it's wise to set up different connection pool name for monitoring/debugging purposes. I would said that having 3 connection pools with same name is bad practice, so it should not be in reference conf.
Hi @Zuchos,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
These files are not only for the tests, but we also link to this file in the documentation: https://doc.akka.io/docs/akka-persistence-jdbc/current/#sharing-the-database-connection-pool-between-the-journals
I guess it makes sense to configure these settings for all databases, so that our documentation includes the pool names in the examples
In that case, we should have for all DBs and also for the shared db settings.
@Zuchos Is this something you would like to complete or shall we close? Then it should include that setting for the other database configuration also.
Closing for inactivity.