akka-management icon indicating copy to clipboard operation
akka-management copied to clipboard

Clarify when to shut down Akka management

Open sebarys opened this issue 6 years ago • 3 comments

Hi,

I have a question: do I need to manually stop akka-management in my custom Task when using akka coordinated shutdown extension ( https://doc.akka.io/docs/akka/2.5.6/scala/actors.html#coordinated-shutdown )?

Additionally I found in akka-management documentation sentence: "In a dynamic environment you might stop instances of Akka Management, for example if you don’t want to free up resources taken by the HTTP server serving the Management routes." ( https://developer.lightbend.com/docs/akka-management/current/akka-management.html#stopping-akka-management ) Should not it be rather "if you want to free up" instead of "if you don’t want to free up" ?

Thanks, sebarys

sebarys avatar Sep 07 '18 13:09 sebarys

I don't think there is a need for explicit stopping from coordinated shutdown. The ActorSystem is anyway about to be stopped and Akka Management will be stopped with that at the end.

The negation must be wrong.

I also think that advice can be misleading if used together with Bootstrap.

patriknw avatar Sep 14 '18 15:09 patriknw

Yep new nodes will need the http endpoints for bootstrap so we can fix the docs under this issue

chbatey avatar Sep 18 '18 06:09 chbatey

btw, the negation was deleted here #334 https://github.com/akka/akka-management/pull/334/files#diff-4fec015fc27c67d13e5612cfbc1dcfd5R125

glammers1 avatar Dec 12 '18 16:12 glammers1