akka-http icon indicating copy to clipboard operation
akka-http copied to clipboard

docs: fix exception handler examples not compiling

Open FlorianCassayre opened this issue 3 years ago • 6 comments

References #3971 and #1465

The changes are analogous to the ones in the above-referenced PR. Additionally, I verified that no other examples were affected by a similar issue.

FlorianCassayre avatar Dec 14 '21 10:12 FlorianCassayre

Hi @FlorianCassayre,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Dec 14 '21 10:12 lightbend-cla-validator

(CLA signed)

FlorianCassayre avatar Dec 14 '21 11:12 FlorianCassayre

After all this didn't compile correctly...

jrudolph avatar Feb 10 '22 15:02 jrudolph

Well, the example does compile but seems to trigger a warning in this workflow (which is interpreted as an error). I'll see what I can do.

FlorianCassayre avatar Feb 10 '22 15:02 FlorianCassayre

Close-open to retrigger validation

johanandren avatar Sep 01 '22 11:09 johanandren

Seems like a relevant compiler error:

[error] /home/runner/work/akka-http/akka-http/docs/src/test/scala/docs/http/scaladsl/server/ExceptionHandlerExamplesSpec.scala:165:64: Selecting value myExceptionHandler from object MyApp, which extends scala.DelayedInit, is likely to yield an uninitialized value [error] Get() ~> handleExceptions(MyExplicitExceptionHandler.MyApp.myExceptionHandler) {

johanandren avatar Sep 01 '22 11:09 johanandren

I see you're closing the PR, but do you have any fix for the underlying problem?

FlorianCassayre avatar Nov 08 '22 13:11 FlorianCassayre

Mostly closing because of inactivity, with no work pushed since almost a year I thought it was abandoned, if you still want to investigate/fix please re-open and push a fix that fixes the compilation error!

johanandren avatar Nov 08 '22 14:11 johanandren