akka-http icon indicating copy to clipboard operation
akka-http copied to clipboard

Published 20 hours ago • verified publisher icon akka

Allow parsing.max-content-length = 0

Open strelec opened this issue 4 years ago • 6 comments
trafficstars

java.lang.IllegalArgumentException: requirement failed: if set max-content-length must be > 0

This should simply require all requests to have empty bodies (for example, a server that only serves GET requests.)

strelec avatar Sep 13 '21 23:09 strelec

Thanks, @strelec, that might make sense (but there might be some reasons it was done the way it is). Would you like to create a PR for that feature?

jrudolph avatar Sep 14 '21 08:09 jrudolph

Hi Everyone, Has the issue been resolved? Also, lemme know if I'm wrong, we just need to change the value of akka.http.client.parsing.max-content-length to 0 from 20m and if the issue is still open so, I would like to pick this issue.

GKuldeepak-Knoldus avatar Dec 26 '21 13:12 GKuldeepak-Knoldus

Thanks, @GKuldeepak-Knoldus. Yes, this issue is still up for grabs, so please go ahead!

jrudolph avatar Jan 10 '22 09:01 jrudolph

Thanks @jrudolph , I have raised a PR for the same. I have set the value to 0 for now, please lemme know, if it required anything further.

GKuldeepak-Knoldus avatar Jan 10 '22 18:01 GKuldeepak-Knoldus

Hi Everyone! Since the linked PR has been rejected, can I try to fix this issue?

soo-underground avatar Jun 06 '22 05:06 soo-underground

Sure, have a crack at it.

strelec avatar Jun 06 '22 09:06 strelec