akka-http icon indicating copy to clipboard operation
akka-http copied to clipboard

Published 20 hours ago • verified publisher icon akka

+htp #1025 Implement client pool monitoring

Open jypma opened this issue 7 years ago • 21 comments

This commit introduces a first attempt at a generic statistics and metrics mechanism to akka-http, so we can allow users to use their monitoring implementation of choice.

Metrics are sent to the system event bus through HttpMeasurements messages, which wrap a sealed trait (right now limited to Gauge only).

This commit adds client pool monitoring only, but for both pool implementations. We can later add request monitoring (times, status codes), and server monitoring.

Fixes #1025 .

jypma avatar Sep 28 '17 08:09 jypma

This may also make issues like https://github.com/akka/akka-http/issues/843 and https://github.com/akka/akka-http/issues/1186 easier to debug, by showing how much is connected / queued up at any point in time.

jypma avatar Sep 28 '17 08:09 jypma

Test FAILed.

akka-ci avatar Sep 28 '17 08:09 akka-ci

Test FAILed.

akka-ci avatar Sep 28 '17 09:09 akka-ci

Test PASSed.

akka-ci avatar Sep 28 '17 10:09 akka-ci

@akka/akka-http-team tests green, ready for review.

jypma avatar Sep 28 '17 10:09 jypma

Thanks a lot, @jypma. Just wanted to say, that I didn't get to reviewing your PRs in detail due to holidays and other duties. Will hopefully get to it soon!

jrudolph avatar Oct 10 '17 15:10 jrudolph

This looks neat, any updates?

ANorwell avatar Oct 31 '17 20:10 ANorwell

@ANorwell there is new Pool implementation under way: https://github.com/akka/akka-http/pull/1533

gosubpl avatar Nov 20 '17 16:11 gosubpl

Test FAILed.

akka-ci avatar Nov 21 '17 11:11 akka-ci

Test FAILed.

akka-ci avatar Apr 09 '18 16:04 akka-ci

Test FAILed.

akka-ci avatar Sep 03 '18 12:09 akka-ci

Test FAILed.

akka-ci avatar Sep 03 '18 12:09 akka-ci

Test FAILed.

akka-ci avatar Sep 04 '18 07:09 akka-ci

Test FAILed.

akka-ci avatar Sep 04 '18 07:09 akka-ci

Test PASSed.

akka-ci avatar Sep 04 '18 08:09 akka-ci

@akka/akka-http-team Tests green. Anyone willing to take a look?

jypma avatar Sep 04 '18 08:09 jypma

Test FAILed.

akka-ci avatar Mar 05 '19 11:03 akka-ci

Test FAILed.

akka-ci avatar Mar 05 '19 12:03 akka-ci

Did this ever go anywhere? Happy to jump in and help push this forward if it's needed.

zackangelo avatar Sep 07 '19 00:09 zackangelo

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

lightbend-cla-validator avatar Mar 08 '21 13:03 lightbend-cla-validator

Test FAILed.

!!! Couldn't read commit file !!!

akka-ci avatar Mar 08 '21 13:03 akka-ci