akka-grpc icon indicating copy to clipboard operation
akka-grpc copied to clipboard

Feat/grpc transcoding

Open GreyPlane opened this issue 2 years ago • 11 comments

inherit the work from #1583 since it's likely abandoned

GreyPlane avatar Sep 22 '23 09:09 GreyPlane

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Sep 22 '23 09:09 lightbend-cla-validator

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Sep 23 '23 09:09 lightbend-cla-validator

weird blocking issue scalapb/ScalaPB#1583

GreyPlane avatar Sep 27 '23 08:09 GreyPlane

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Sep 27 '23 09:09 lightbend-cla-validator

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Oct 01 '23 05:10 lightbend-cla-validator

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Oct 01 '23 06:10 lightbend-cla-validator

I think this is ready to go, the implementation itself is stable enough to review, while I'm still working on adding more tests and documentations.

GreyPlane avatar Oct 01 '23 06:10 GreyPlane

Nice to see work here but just so you know: we don't quite have the bandwidth to properly keep up with reviewing this PR right now, so don't think of it as something that will get merged soon.

johanandren avatar Oct 02 '23 08:10 johanandren

Nice to see work here but just so you know: we don't quite have the bandwidth to properly keep up with reviewing this PR right now, so don't think of it as something that will get merged soon.

That's understandable, just knowing you guys are interested on this is enough.

GreyPlane avatar Oct 02 '23 09:10 GreyPlane

Hi @WayneWang12,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

lightbend-cla-validator avatar Oct 03 '23 11:10 lightbend-cla-validator

  • Gradle plugin wouldn't generate ScalaPB classes for library protos, which causes generated Scala proto classes(user side) failed to use HTTP transcoding related proto classes, I've added these into protoSrc, but not very confident it's the right thing to do.
  • Scripted test reported huge duplicated generated proto classes, mainly from google.api.*, which I haven't figure out how to deal with.

I think these two are the remaining blocker, but it's hard to solve due I'm lacking relative experience, so any help or suggestion was appreciate.

GreyPlane avatar Feb 19 '24 06:02 GreyPlane