friends icon indicating copy to clipboard operation
friends copied to clipboard
verified publisher icon akirk

When the FediPress plugin is activated the edit post link does not work

Open amelciaao opened this issue 10 months ago • 9 comments

As in the title. When the FediPress plugin is active it is not possible to edit posts because the “edit post” link redirects to the post on the frontend. I don't see any errors in the logs from the Frends plug-in series.

amelciaao avatar Feb 04 '25 20:02 amelciaao

Is this the "edit post" link you had in mind, in the WordPress admin bar?

Image

I assume the FediPress plugin you use on your site is this one? https://github.com/alquimidia/fedipress

jeherve avatar Feb 05 '25 21:02 jeherve

Yes, I use the plugin from this link. The non-working button is available in two places: the admin bar - your screenshot and next to each post item - the highlighted item in the screenshot.
Glossary: wpisy - posts

Image

P.S. Sory I have the Polish language set. I hope this is not a problem.

amelciaao avatar Feb 05 '25 21:02 amelciaao

Thanks for explaining, where does the link go exactly? to a /friends/1234/ like URL?

akirk avatar Feb 06 '25 14:02 akirk

No. The link goes to /category/slug-post.

amelciaao avatar Feb 06 '25 16:02 amelciaao

I can't see a clear reason why this should be caused by the FediPress theme plugin. Can you confirm that the links work again if you deactivate FediPress (but keep the Friends plugin)?

akirk avatar Feb 07 '25 14:02 akirk

Yes, I confirm that with FediPress disabled and the Friends plugin enabled, everything works fine. I disabled all other plugins to make sure that there are no interactions between all plugins.

I myself do not see a correlation of the bug with the FediPress code. Need some information on WP configuration, debug.log (Friends and FediPress do not report any error, warning)?

amelciaao avatar Feb 08 '25 11:02 amelciaao

Hi @amelciaao and @jeherve I solved this problem in the V1.0.2 Fedpress version. I'll send a PR to Friends plugins.json ok, @akirk ?

liviacarolgouvea avatar Feb 12 '25 17:02 liviacarolgouvea

Oh, great find, @liviacarolgouvea . I've merged the PR. The fix that you made seems I should rather make inside the Friends plugin. I just still cannot reproduce it or understand why your fix helps, do you have further steps to reproduce?

akirk avatar Feb 13 '25 11:02 akirk

Hi @akirk

The Fedpress friends_frontend_post_types filter is used to display blog posts on friends' timeline.

Before this commit, the filter was impacting the edition of other pages. This condition is therefore added to apply only to the Friends page.

It was a problem with the Fedipress plugin, I think there is no need to correct it in Friends.

liviacarolgouvea avatar Feb 14 '25 19:02 liviacarolgouvea