Akira icon indicating copy to clipboard operation
Akira copied to clipboard

Different keyboard layouts

Open albfan opened this issue 6 years ago • 5 comments

Expected Behavior

Zoom in shortcut Ctrl+= is not standard and breaks the workflow in spanish.

Typical zoom shorcuts are:

  • Ctrl++: Zoom in
  • Ctrl+-: Zoom out
  • Ctrl+0: Reset zoom

I check other programs (tilix https://github.com/gnunn1/tilix/blob/master/data/gsettings/com.gexperts.Tilix.gschema.xml#L1191) and this is pretty standard.

In spanish Ctrl++ is a direct key press. To use Ctrl+=, we need to press Ctrl+Shift+0.

Seems in english is the opposite and Ctrl++ is not a direct keypress.

Current Behavior

Ctrl+= executes zoom in.

Possible Solution

  • Stick to standards.
  • Deal with this in a l10n way
  • Allow to customize shortcuts

Context

  • Akira Version: master
  • OS Info: Arch linux

albfan avatar Oct 13 '19 09:10 albfan

Ah! That makes sense, that's why we were colliding on that. I Think for now we can stick to standards and then allow shortcut customization, so we don't need to handle localization for keyboard shortcuts, which it could get pretty hairy. Thanks for investigating this.

Alecaddd avatar Oct 13 '19 19:10 Alecaddd

Should we set to Ctrl + + then?

albfan avatar Oct 14 '19 06:10 albfan

Yes, let's leave it like it is right now, after your update to master. What do you think?

Alecaddd avatar Oct 14 '19 06:10 Alecaddd

I think right now is Ctrl + =.

Any idea about how zoom in and out should behave? I think zoom in is not intuitive right now ( but can find how to make it more natural) Looking at other apps may work, but any idea is appreciated.

albfan avatar Oct 14 '19 06:10 albfan

You updated master here: https://github.com/akiraux/Akira/blob/master/src/Services/ActionManager.vala#L89 So it's plus, let's leave it like that for now.

For the zoom, I'm taking care of that in the canvas-action branch, I should have a PR ready for review tomorrow. Here's the behaviour:

Zoom in: CTRL + Scroll Up Zoom out: CTRL + Scroll down

Is this what were you asking? Sorry if I didn't understand your question :sweat_smile:

Alecaddd avatar Oct 14 '19 06:10 Alecaddd