react-slick icon indicating copy to clipboard operation
react-slick copied to clipboard

Fix clicking next/prev arrows when initialSlide is not 0

Open jorrit opened this issue 3 years ago • 10 comments

This PR fixes #1946.

This bug got introduced with change 1c3d70cce795fe2daaeb4b57ce4013fd08b997aa. When initialSlide is set, targetSlide was not set to the right value. This is fixed.

Also, I think the intended change of 1c3d70cce795fe2daaeb4b57ce4013fd08b997aa can be implemented slightly simpler, by just checking if the new value is out of the allowed bounds.

jorrit avatar May 07 '21 08:05 jorrit

Please, merge this

felipe-gustavo avatar May 28 '21 13:05 felipe-gustavo

Hello all, what's the status of this PR, I'm needing this fixed.

apntzls avatar Jul 19 '21 13:07 apntzls

Is there any way we can get a timeline on when to expect this merged?

JoaoCSR avatar Aug 20 '21 21:08 JoaoCSR

Please, merge this +1

yenienRey avatar Sep 03 '21 15:09 yenienRey

Do you have any news?

dramoturg avatar May 05 '22 11:05 dramoturg

This repo has had very little movement in the last year. I see there are many open pull requests just waiting to be merged. Who has write access? If it's only @akiran, can we petition to get others to help maintain this project?

gtb104 avatar Jul 15 '22 18:07 gtb104

This issue is already fixed

akiran avatar Jul 21 '22 19:07 akiran

If it’s already fixed, could you please point to the PR and release that addresses this issue? Ant design uses this library in their Carousel component. If there’s a specific version they should be at, then I’ll make a PR to pull in the correct version on their repo.

gtb104 avatar Aug 19 '22 12:08 gtb104

come on, it's 2022 !!

AttackXiaoJinJin avatar Nov 09 '22 07:11 AttackXiaoJinJin