bufferline.nvim icon indicating copy to clipboard operation
bufferline.nvim copied to clipboard

fix(util): flip logic to determine version specific utils.is_list

Open nikoksr opened this issue 1 year ago • 2 comments

Summary

PR #892 completely broke my setup. After some investigation, flipping the logic for choosing the correct is_list util function seems to fix it for me. I can't confirm whether this is true for neovim versions < v0.10.0.

Misc

Neovim version:

NVIM v0.10.0-dev-2671+gdc110cba3c
Build type: RelWithDebInfo
LuaJIT 2.1.1710088188
Run "nvim -V1 -v" for more info

Edit: Obsolete; read below.

nikoksr avatar Apr 22 '24 08:04 nikoksr

I dug a little deeper and it turns out that the original PR will work once this hits the AUR.

Nightly on Arch is the version that I shared in the opening comment, actual latest nightly is:

NVIM v0.10.0-dev-2976+g208852126
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068

I'll leave this PR open anyway, so others that encounter this issue get an idea what's wrong. Thanks for your work on this plugin ✌🏽

nikoksr avatar Apr 22 '24 09:04 nikoksr

Apologies did not see your comment


This will break both people who install nvim from recent pre-release and using prior 0.10.0(stable release), since both your version and newest version are 0.10.0 it's pretty hard to do the check here. I think the better way is for you to upgrade your neovim as that's the way moving forward.

RayGuo-ergou avatar Apr 22 '24 13:04 RayGuo-ergou