ble.sh icon indicating copy to clipboard operation
ble.sh copied to clipboard

[zellij 0.40.1] Zellij

Open gvlassis opened this issue 1 year ago • 2 comments

Hello!

I just noticed that when bleopt complete_auto_menu=1, the menu options do not disappear inside Zellij when the menu closes. I attach a video showing the glitch.

https://github.com/akinomyoga/ble.sh/assets/74119653/c54b4745-024c-4976-b4cf-9b2cce2dac39

gvlassis avatar May 25 '24 11:05 gvlassis

This is a bug of Zellij. I also found another bug causing problems with ble.sh. I submitted PRs to the upstream.

The terminal implementation by Zellij seems sloppy as I found even other three bugs in checking only the related part. In addition, the DA2 report by Zellij seems indistinguishable from that by Alacritty. They are using the conflicting range of the terminal IDs.

akinomyoga avatar May 27 '24 13:05 akinomyoga

The fixes are merged in the upstream Zellij, which is an impressive speed.

@gvlassis Could you check the behavior in the latest version of Zellij?

edit: To build and install the latest main branch of Zellij from the source, one can use the following commands:

$ git clone [email protected]:zellij-org/zellij.git
$ cd zellij
$ cargo xtask install "${CARGO_HOME:-$HOME/.cargo}/bin/zellij"

The command cargo install --locked zellij suggested in Zellij's README doesn't work because it builds the last release version 0.40.1 of Zellij, which is not the current main branch.

akinomyoga avatar May 27 '24 15:05 akinomyoga

I confirm that your commits fixed the issue! Let's wait until they roll out downstream 🤞.

gvlassis avatar Jul 29 '24 19:07 gvlassis

Thank you for the confirmation!

akinomyoga avatar Jul 29 '24 21:07 akinomyoga