userscript icon indicating copy to clipboard operation
userscript copied to clipboard

feat: support any website

Open skbeh opened this issue 2 years ago • 10 comments

skbeh avatar Dec 17 '22 12:12 skbeh

Great works, but mediaCore doesn't work for pages with video in the iframe.

akiirui avatar Dec 17 '22 18:12 akiirui

@akiirui Can you give me any example?

skbeh avatar Dec 18 '22 00:12 skbeh

@akiirui Can you give me any example?

Such as https://live.bilibili.com/13

akiirui avatar Dec 18 '22 03:12 akiirui

@akiirui FFMpeg not supports HEVC inside FLV yet.

skbeh avatar Dec 18 '22 04:12 skbeh

@akiirui FFMpeg not supports HEVC inside FLV yet.

Yep, I know. but it's just an example for pages with video in the iframe.

This live streaming has other source, I will fix it (to select other source fmp4+hevc or flv+h264)

akiirui avatar Dec 18 '22 04:12 akiirui

@akiirui After https://github.com/yt-dlp/yt-dlp/pull/5820 being merged, my script should works fine with bilibili live.

skbeh avatar Dec 18 '22 07:12 skbeh

@akiirui After yt-dlp/yt-dlp#5820 being merged, my script should works fine with bilibili live.

I think you should test with the example page, your script doesn't show the play icon in the page.

akiirui avatar Dec 18 '22 08:12 akiirui

Sorry, I forget to push the latest changes.

skbeh avatar Dec 18 '22 08:12 skbeh

Sorry, I forget to push the latest changes.

Thanks, I have a test for latest commit.

metadata @run-at shouldn't be document-body, only Tampermonkey supports it.

https://violentmonkey.github.io/api/metadata-block/#run-at https://wiki.greasespot.net/Metadata_Block#@run-at

And I see you're using codes from other author https://github.com/xxxily/h5player. But this repo doesn't give any license, I won't merge these codes without a license.

There still many sites aren't supported by yt-dlp, if the script shows icon but cannot be played, it's bad expreince for users.

At last, thanks for your work. You can forking this repository (MIT license) and public your version to GreasyFork.

akiirui avatar Dec 18 '22 10:12 akiirui

https://greasyfork.org/zh-CN/scripts/381682-html5视频播放器增强脚本 shows that it is licensed under GPL, so the source should also be licensed under GPL. Related issue: https://github.com/xxxily/h5player/issues/501

skbeh avatar Dec 18 '22 10:12 skbeh