Aziz Khoury

Results 134 comments of Aziz Khoury

if you use any of these 4 functions, https://github.com/simonlast/node-persist/blob/master/src/local-storage.js#L133-L166 yes, it seems that is in fact reading everything to ram, temporarily, this should be garbage collected since we don't maintain...

Also, I dont recommend using this library for handling large or high concurrent transactions, maybe something like redis is better for your case. node-persist is designed as a light weight...

you are right!, cleaning up expired does in fact load everything, that's a bug that i will fix.

not how it is today, but maybe with some adjustments to how we write/read files https://github.com/simonlast/node-persist/blob/84654f9ed02bdc085ee06ba9ca6dfdad6ff9948f/src/local-storage.js#L390-L400 https://github.com/simonlast/node-persist/blob/84654f9ed02bdc085ee06ba9ca6dfdad6ff9948f/src/local-storage.js#L304-L318

[`findIndex`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex) accepts a test function. Also you don't need to iterate twice, see the [polyfill](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex#Polyfill) for example.

how would we know that it's incorrect?

it does, but I believe it admins can only moderate posts flagged by other users. if akismet flags a post, it doesn't get even get created. We could let it...

crap. closed the wrong one.

@a5mith you want multi language support? find an alternative module :)