podgrab icon indicating copy to clipboard operation
podgrab copied to clipboard

Empty files are being downloaded i.e. 0KB

Open shooftie opened this issue 2 years ago • 13 comments

  • Installation Type: Docker
  • Have you tried using the latest docker image / code base: yes

Describe the bug

When downloading a specific podcast the output files are 0KB.

To Reproduce

  1. Add "Hamish & Andy" podcast either using in-built search or via the rss feed
  2. Click "Download all episode files" or simply download a single file
  3. Examine the output files, they are 0KB.

Expected behavior The files should have some content.

Screenshots

image

Additional context

When visit the url for a media file in the browser directly e.g. this one, everything works fine.

When looking at the URL...

https://chtbl.com/track/CFD1E3/traffic.omny.fm/d/clips/820f09cf-2ace-4180-a92d-aa4c0008f5fb/0786e9ff-0519-43d3-a0cd-aa4c0176ad25/67018c0b-d76d-4fc5-aee5-adaa0004f059/audio.mp3?utm_source=Podcast&in_playlist=2bf97b40-59cd-424a-ba35-aa4c0176ad25

...you can see that there are some query params added...

...audio.mp3?utm_source=Podcast&in_playlist=2bf97b40-59cd-424a-ba35-aa4c0176ad25

...might this be the issue?

shooftie avatar Feb 05 '22 17:02 shooftie

Same, but only for some files !

erdoukki avatar Mar 24 '22 07:03 erdoukki

Let me chck

On Thu, 24 Mar 2022 at 13:18, Kerma Gérald @.***> wrote:

Same, but only for some files !

— Reply to this email directly, view it on GitHub https://github.com/akhilrex/podgrab/issues/188#issuecomment-1077332131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEMVPVTPSRRTXOXGOFQVQDVBQM3NANCNFSM5NUG5RPQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Thanks and Regards, Akhil Gupta

akhilrex avatar Mar 24 '22 12:03 akhilrex

There is a redirect on this. I just had the same issue trying to use cURL. You have to specifically tell it to follow redirects -L, might this be an issue here? I don't know how Go works in this respect.

shooftie avatar Mar 29 '22 19:03 shooftie

In fact, there are two redirects... image

shooftie avatar Mar 29 '22 19:03 shooftie

@erdoukki seeing as you are getting some successes and some failures, can you see whether the presence of a redirect is the difference?

shooftie avatar Mar 30 '22 11:03 shooftie

In fact, there are two redirects...

@shooftie What tool did you used ?

erdoukki avatar Apr 04 '22 08:04 erdoukki

Some files look to be too small, so I deleted it locally but they do not seen as needed to be re-downloaded...

May be some full-check with re-downloaded request may be added ? Or some task to health check the local files status from remote files (size, hash, whatever...) ?

erdoukki avatar Apr 04 '22 08:04 erdoukki

@erdoukki I just used devtools.

https://user-images.githubusercontent.com/2161844/161585646-07bc7367-9832-43a0-8542-68acc5511a7b.mov

Sorry the video is so small. GH have a limit of 10MB.

shooftie avatar Apr 04 '22 16:04 shooftie

May be some full-check with re-downloaded request may be added ?

Yo @erdoukki see this issue, what you are asking should happen as long as you have set Podgrab to do otherwise.

Screenshot 2022-04-05 at 11 58 05

In my case, I move all of the podcasts out of their download location into a library and so absolutely do not want them to be re-downloaded.

shooftie avatar Apr 05 '22 11:04 shooftie

The multiple redirect issue was fixed and pushed some time back. Is this issue still present?

akhilrex avatar Jul 07 '22 08:07 akhilrex

I just pulled the latest image and I am still seeing the issue.

I only see this on one of my podcasts, I'm not sure whether that is just a coincidence. Are you able to test it for me on you end?

https://www.omnycontent.com/d/playlist/820f09cf-2ace-4180-a92d-aa4c0008f5fb/0786e9ff-0519-43d3-a0cd-aa4c0176ad25/2bf97b40-59cd-424a-ba35-aa4c0176ad25/podcast.rss

Thanks.

shooftie avatar Jul 07 '22 17:07 shooftie

If I can contr5ibute to help on tests ? I get the same issues from some streams on working podcast sources... some files are missing, they are here but 0 size...

erdoukki avatar Sep 19 '22 09:09 erdoukki

@akhilrex, any ideas on this?

shooftie avatar Oct 10 '22 22:10 shooftie