wuff icon indicating copy to clipboard operation
wuff copied to clipboard

osgiExecutionEnvironment cannot be customized

Open ylemoigne opened this issue 10 years ago • 2 comments

While in my project (using 'org.akhikhl.wuff.eclipse-rcp-app'), the project.ext.osgiExecutionEnvironment property doesn't exist (yet) and any change will be overwritten

Workaround : afterEvaluate { project -> project.ext.osgiExecutionEnvironment = 'JavaSE-1.7,'+project.ext.osgiExecutionEnvironment }

Worst, the property cannot be unset, so it always end in product configuration.ini file.

I'm ok to fix this issue, but I'm not sure what's the right way. To my mind this property should be set in product configuration DSL (EquinoxAppProductsExtension class) Is there any reason of why it's in project's ext ?

I feel like if I'm missing something

ylemoigne avatar May 09 '15 09:05 ylemoigne

I don't remember why I did put it to project.ext. I looked into the code, I have impression that it's totally OK to move osgiExecutionEnvironment from project.ext to EquinoxAppProductsExtension.

akhikhl avatar May 11 '15 21:05 akhikhl

BTW, the property can be unset by project.ext.osgiExecutionEnvironment = null

akhikhl avatar May 21 '15 12:05 akhikhl