jansson icon indicating copy to clipboard operation
jansson copied to clipboard

Compiler warning -Werror=stringop-truncation fix for error.c

Open sbytnar opened this issue 1 year ago • 1 comments

Hi. This warning is emitted by newer versions of gcc. The project I'm working with treats this particular warning as an error. The fix below makes the compiler happy.

The full error message emitted looks like this:

| jansson/src/error.c: In function 'jsonp_error_set_source':
| jansson/src/error.c:25:9: error: '__builtin_strncpy' specified bound depends on the length of the source argument [-Werror=stringop-truncation]
|    25 |         strncpy(error->source, source, length + 1);
|       |         ^
| In function 'jsonp_error_set_source',
| jansson/src/error.c:17:6:
| jansson/src/error.c:23:14: note: length computed here
|    23 |     length = strlen(source);
|       |              ^~~~~~~~~~~~~~
| cc1: all warnings being treated as errors

Thank you. --Steve

sbytnar avatar Sep 26 '24 21:09 sbytnar

This would fix https://github.com/akheron/jansson/issues/630

sbytnar avatar Sep 26 '24 21:09 sbytnar