jansson icon indicating copy to clipboard operation
jansson copied to clipboard

Published 20 hours ago • verified publisher icon akheron

Make CMAKE_DEBUG_POSTFIX truly optional

Open KOConchobhair opened this issue 5 years ago • 2 comments

The missing piece to fix #385

Add DEFINED to the conditional to allow the user to set CMAKE_DEBUG_POSTFIX to blank which will disable the _d suffix on Windows builds. Othwerise, the default jansson cmake behavior is unchanged.

KOConchobhair avatar Mar 20 '19 18:03 KOConchobhair

Coverage Status

Coverage decreased (-0.8%) to 95.585% when pulling 62aaa1db576e117ecf2634ffb2e23ff28a68a7eb on KOConchobhair:optional-cmake-debug-postfix into b333f3656d6a408fe38737982d854b80ea870803 on akheron:master.

coveralls avatar Mar 20 '19 19:03 coveralls

LGTM! It is a better way to set the value of CMAKE_DEBUG_POSTFIX. It's also seen in curl project like 73a3b3e0

harkue avatar Oct 09 '19 02:10 harkue