Albin Kerouanton

Results 36 issues of Albin Kerouanton

**- What I did** `(*Endpoint).sbJoin()`, `(*Endpoint).sbLeave()` start by calling `(*Network).getEndpointFromStore()` before doing anything else. In turn this method calls `(*Store).GetObject()` with a freshly created `*Endpoint` instance, meaning the `*Endpoint` instance...

status/2-code-review
area/networking
kind/refactor

**- What I did** - Resolve moby/moby#46615. - Revert commit ee9e52676409b2e428a816ac59f42f5ba61089dd from https://github.com/moby/moby/pull/42598 - reopens https://github.com/moby/moby/issues/41525 - reopens https://github.com/moby/moby/issues/33925 Route scope is used by the kernel to choose what source...

status/2-code-review
area/networking
kind/bugfix

- Related to https://github.com/moby/moby/pull/46853 **- What I did** Starting with API v1.45, the container short ID is removed from the container Aliases. Update the status for that deprecation.

impact/deprecation
area/networking

Related to: - https://github.com/moby/moby/pull/47427 **- What I did** Update the "Deprecated Engine Features" doc page.

kind/docs
status/3-docs-review
area/networking

- Close https://github.com/moby/moby/issues/40275 - Close https://github.com/moby/moby/issues/42801 - Supersede / Close https://github.com/moby/moby/pull/43033 - Stacked on top of https://github.com/moby/moby/pull/47727 **- What I did** This previous allocator was subnetting address pools eagerly when...

status/2-code-review
kind/enhancement
area/networking
impact/changelog
area/networking/ipam

- Related to https://github.com/docker/go-connections/pull/104 - `TestConfigServerExclusiveRootPools`: see https://github.com/docker/go-connections/blob/5cc4da5c08cd0df3e0a45da21ebd07e131109bd2/tlsconfig/config_test.go#L202-L205 - `TestConfigClientExclusiveRootPools`: see https://github.com/docker/go-connections/blob/5cc4da5c08cd0df3e0a45da21ebd07e131109bd2/tlsconfig/config_test.go#L566-L569 Both tests break with the following error: > Unable to verify certificate 1: x509: certificate signed by unknown...

**- What I did** Libnet's method `(*Network).createEndpoint()` is already parsing this netlabel to set the field `ep.iface.mac`. Later on, this same method invoke the driver's method `CreateEndpoint` with an `InterfaceInfo`...

area/networking
kind/refactor

**- What I did** Prior to this change PoolID microformat was using slashes to separate fields. Those fields include subnet prefixes in CIDR notation, which also includes a slash. This...

status/2-code-review
area/networking
kind/refactor
area/networking/ipam

- This is a follow-up of https://github.com/moby/moby/pull/47810 (see this comment: https://github.com/moby/moby/pull/47810#issuecomment-2102458033) #### libnet: init datastore in ctrler constructor This was done in a separate method, called by the ctrler constructor....

area/networking
kind/refactor

CORS headers were originally added by 6d5bdff. These headers could be set without any Authz plugin enabled beforehand, making this feature quite dangerous. This commit marks the daemon flag `api-cors-header`...

area/api
status/2-code-review
impact/changelog
impact/deprecation