pim-community-dev
pim-community-dev copied to clipboard
akeneo
Product API: include search_locale in pagination links
Previously, the pagination links in both Product and ProductModel list api responses would have the search_locale param stripped if it was used. This meant that the first page would be retrieved, but then following the nextLink url in the response would throw a 422 when visited (because of a lack of search_locale).
Definition Of Done (for Core Developer only)
| Q | A |
|---|---|
| Added Specs | - |
| Added legacy Behats | - |
| Added acceptance tests | - |
| Added integration tests | OK |
| Changelog updated | Todo |
| Review and 2 GTM | Todo |
| Micro Demo to the PO (Story only) | - |
| Migration script | - |
| Tech Doc | - |
Todo: Pending / Work in progress
OK: Done / Validated
-: Not needed
I'm not sure which of the above is my responsibility. I've added to the only tests I was able to find that cover this code, but I'm not sure which category these fall into.
Also, this is a more complete fix than #11723 (which seems to have been accidentally closed by an unrelated commit)
Closes #11722
Not sure what else to do here, this fixes an existing bug and updates the tests accordingly.
This fixes a real bug that we ran into. It's not an enhancement that needs discussion, it adds something that was obviously left out on accident and adds tests to ensure it stays fixes.
Is there something else that needs doing before this accepted?
I fixed your bug more than two years ago. Not sure what else to do here...