causality icon indicating copy to clipboard operation
causality copied to clipboard

Should this line be "del matched_treated['treated_index']"?

Open ZJianL opened this issue 1 year ago • 2 comments

https://github.com/akelleh/causality/blob/aa458538224ec162b751c1e225b1ff02cb474191/causality/estimation/parametric.py#L201C34-L201C34 In the get_treated_matches function of the PropensityScoringModel class, after join, did you mean to delete the treated_index instead of control_index? Because I think what we need in the matched_treated is the control_index which has been deleted in this version.

ZJianL avatar Oct 11 '23 07:10 ZJianL

I think so too.

cjqjyy avatar Nov 11 '23 03:11 cjqjyy

https://github.com/akelleh/causality/blob/aa458538224ec162b751c1e225b1ff02cb474191/causality/estimation/parametric.py#L201C34-L201C34 del matched_treated['control_index'] should be del matched_treated['treated_index']

cjqjyy avatar Nov 11 '23 03:11 cjqjyy