polyclip-go icon indicating copy to clipboard operation
polyclip-go copied to clipboard

golint fixes

Open stanim opened this issue 10 years ago • 4 comments

Only golint fixes. See also: https://golang.org/doc/effective_go.html#mixed-caps

stanim avatar Jul 03 '15 21:07 stanim

It can be: MINMAXX XMINMAX minMaxX xMinMax

Capital words are allowed without underscore. I have no preference, so I can change it it whatever @akavel prefers.

stanim avatar Jul 03 '15 21:07 stanim

This is pretty minor, and I'm okay with the last 2. But I'm not sure why you'd want to use all capitals for the words "min" and "max". They're not acronyms, are they?

dmitshur avatar Jul 03 '15 23:07 dmitshur

In my own go code I also use only capitals for acronyms. Using capitals for constants is a left over from other languages such as Python. I just left capitals to stay 'nearest' to the original code. For example the source code also contains UNION, DIFFERENCE, etc... I would have changed them as well, but I have no idea what the author of the package wants. In that case I try to keep the difference as small as possible. If @akavel give his preference, I can fix it. Right now I don't want to inflate the commit count.

stanim avatar Jul 04 '15 11:07 stanim

Please make all the changes I listed if you can, and I'll merge it then. If you can't, I'll do them at some (not well defined) point in future myself and merge too. Thanks.

EDIT: sorry: please also add an AUTHORS file in root dir, with your name & email, my name and email, Martinez's name and email & Mahir Iqbal's name & email (as listed in copyright lines in most files); sorted in alphabetical order as in AUTHORS file in golang repo (don't remember if it's by first or last name). Thanks and sorry for trouble.

EDIT: Iqbal seems to have not left an email, so please do it without one. If it's not too big a trouble for you to add a line with // Copyright (c) polyclip-go Authors (see AUTHORS file) to *.go, please do, but that's not mandatory.

akavel avatar Jul 13 '15 11:07 akavel