keepa icon indicating copy to clipboard operation
keepa copied to clipboard

Published 20 hours ago • verified publisher icon akaszynski

Missing product query options

Open spi-jbu opened this issue 3 years ago • 4 comments

The 'days' and 'only-live-offers' options for a product query are not implemented in the library.

Thanks

spi-jbu avatar Mar 12 '21 22:03 spi-jbu

I don't see those parameters in the Keepa Product Search documentation, could you specify by linking documentation? https://keepa.com/#!discuss/t/product-searches/109

dehidehidehi avatar Mar 12 '21 23:03 dehidehidehi

They are in the Product Request page at:

https://keepa.com/#!discuss/t/request-products/110

spi-jbu avatar Mar 13 '21 13:03 spi-jbu

I have opened a pull request for this feature implementation: https://github.com/akaszynski/keepa/pull/96

I have not been able to implement 'days' parameter... as I discuss over there. If we could redirect discussions over there that would be great!

dehidehidehi avatar Mar 13 '21 16:03 dehidehidehi

I closed my previous PR by mistake, but my implementation was not working. However I believe I got everything to work (tests are passing) in this PR: https://github.com/akaszynski/keepa/pull/98

dehidehidehi avatar Mar 27 '21 18:03 dehidehidehi