node icon indicating copy to clipboard operation
node copied to clipboard

chore: address all todo

Open troian opened this issue 5 years ago • 4 comments

currently there are 60 todo items and it is good to start tracking them as issues. also when creating new todo or fixme new it should have reference to either new or existing issue for example todo (#788) bla bla

image

troian avatar Aug 27 '20 15:08 troian

also adding github-action to parse commit and check new todos matching regexp like this ^\s*// (todo|TODO|fixme|FIXME) \(#\d+\)\s\w+

@boz @Ropes thoughts?

troian avatar Aug 27 '20 15:08 troian

Would the Github Action only detect new TODO's or would it also flag all existing ones?

Ropes avatar Aug 27 '20 16:08 Ropes

depends how check is implemented. there can be either commit check which is definitely faster as less code to check or through entire code base. i think we should go 1st option but fix all existing todo

troian avatar Aug 27 '20 16:08 troian

actions example https://github.com/marketplace/actions/todo-actions

troian avatar Aug 27 '20 21:08 troian